sdk/trace: removing ApplyConfig and Config #1693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1693 +/- ##
=====================================
Coverage 77.8% 77.9%
=====================================
Files 130 131 +1
Lines 7013 6997 -16
=====================================
- Hits 5463 5451 -12
+ Misses 1299 1296 -3
+ Partials 251 250 -1
|
ijsong
force-pushed
the
remove-config
branch
3 times, most recently
from
433342a
to
e38c0fd
Compare
ijsong
requested review from
Aneurysm9,
dashpole,
evantorrie,
jmacd,
lizthegrey,
MrAlias and
XSAM
as code owners
Aneurysm9
suggested changes
Mar 12, 2021
Aneurysm9
approved these changes
Mar 16, 2021
|
@ijsong sorry about the churn on this, there were several other issues working in the same area though I think we've made it through most of them. @open-telemetry/go-approvers can we get another approval on this so we can land it? |
|
@Aneurysm9 No problem, I fixed some issues after merging main branch, and renamed field name |
XSAM
approved these changes
Mar 17, 2021
MrAlias
reviewed
Mar 17, 2021
This was referenced Mar 17, 2021
ijsong
force-pushed
the
remove-config
branch
4 times, most recently
from
de816d9
to
50af6b7
Compare
MrAlias
reviewed
Mar 18, 2021
This patch removes `ApplyConfig` method and `Config` struct from `go.opentelemetry.io/otel/sdk/trace` package. To ensure valid config for TracerProvider, it adds `ensureValidTracerProviderConfig` private function. Jaeger and Zipkin have been used the `Config` directly across package boundaries. Since `Config` is removed, they can't use it. This change, thus, replaces `WithSDK` with `WithSDKOptions`. Resolves open-telemetry#1636, open-telemetry#1705.
MrAlias
approved these changes
Mar 18, 2021
Merged
This was referenced Mar 27, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch removes
ApplyConfigmethod andConfigstruct fromgo.opentelemetry.io/otel/sdk/tracepackage. To ensure valid config for TracerProvider, it addsensureValidTracerProviderConfigprivate function.Jaeger and Zipkin have been used the
Configdirectly across package boundaries. SinceConfigis removed, they can't use it. This change, thus, replacesWithSDKwithWithSDKOptions.Resolves #1636, #1705.