-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jaeger exporter should be its own go module #205
Comments
@rghetia @iredelmeier will be happy to contribute the new module, can I just reference the new module repo here? |
@eran-levy , yes. Thanks for contributing. |
@rghetia ok will ref soon, wanted to make sure I document the way to generate the thrift clients that we have under internal/gen-go/jaeger - which jaeger version are we compatible with? when I generated using the Makefile that available at: https://github.com/jaegertracing/jaeger/tree/v1.14.0 I didnt see the same files that we have under our internal/gen-go/jaeger folder, how did you generate them? or you just combined them into the one file? |
@eran-levy I did not generate those files. I had simply ported jaeger exporter from opencensus jaeger exporter v0.1.0. |
@rghetia ok np, so here is the repo: https://github.com/eran-levy/opentelemtry-go-exporter-jaeger the discussions around the jaeger go client libs are interesting and i agree that we shall have a single strategy re our clients usage. Currently, i will leave it as is with gen-go as you ported. |
@eran-levy there may be some confusion here. While we have not decided where the exporter would reside, but we want the exporters to be its own module. Similar to examples (example/http, example/basic). Later when we have a place (another repo or different directory within the same repo) we will have another PR to do the change. |
* Add Config struct definition, test files, and testing data * Add tests for Validate method * Implement Validate method * Add Config utility files and testing data * Add helper function to create YAML files for testing * Add NewConfig function, Options interface, and tests * Add Viper tags to Config struct and two With functions * Add test for WithFilepath * Add WithClient and test for WithClient * Remove default for http client and adjust tests * Add check for conflicting authentication types and update tests * Update README.md * Run make precommit * Add example Config struct * Add NewRawExporter for creating an Exporter and TestNewRawExporter * Add NewExportPipeline for creating a controller and TestNewExportPipeline * Add InstallNewPipeline and TestInstallNewPipeline * Update README and run make precommit
* Jaeger exporter should be its own go module open-telemetry/opentelemetry-go#205 * fix review comments and build #205 * resolve mod conflicts #205
Among other things, this would decouple the core code from all the Jaeger dependencies, such as Thrift.
The text was updated successfully, but these errors were encountered: