Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

init go modules for jaeger exporter #237

Merged
merged 5 commits into from
Oct 24, 2019
Merged

init go modules for jaeger exporter #237

merged 5 commits into from
Oct 24, 2019

Conversation

eran-levy
Copy link
Contributor

@eran-levy eran-levy commented Oct 23, 2019 •
edited
Loading

fixes #205

@eran-levy eran-levy closed this Oct 23, 2019
@eran-levy eran-levy reopened this Oct 23, 2019
@eran-levy eran-levy mentioned this pull request Oct 23, 2019
Closed
krnowak
krnowak suggested changes Oct 23, 2019
View reviewed changes
Copy link
Member

@krnowak krnowak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI failed with:

Working tree is not clean, did you forget to run "make precommit"?

On branch pull/237
Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git checkout -- <file>..." to discard changes in working directory)

	modified:   example/basic/go.sum
	modified:   example/http-stackdriver/go.sum
	modified:   example/http/go.sum
	modified:   example/namedtracer/go.sum
	modified:   exporter/trace/jaeger/go.sum
	modified:   go.mod
	modified:   go.sum

no changes added to commit (use "git add" and/or "git commit -a")
make: *** [Makefile:57: test-clean-work-tree] Error 1
Exited with code 2

Not sure if that's relevant to your changes…

exporter/trace/jaeger/README.md Outdated Show resolved Hide resolved
exporter/trace/jaeger/README.md Outdated Show resolved Hide resolved
@eran-levy
Copy link
Contributor Author

thanks @krnowak fixed, see last commits

@rghetia
Copy link
Contributor

rghetia commented Oct 23, 2019

@eran-levy can you please sign the CLA?

@eran-levy
Copy link
Contributor Author

eran-levy commented Oct 23, 2019 •
edited
Loading

@rghetia done signed the CLA

@rghetia
Copy link
Contributor

rghetia commented Oct 23, 2019

@rghetia done signed the CLA

Thanks. There is a conflict in go.mod. Can you please rebase/resolve the conflict?

@eran-levy
Copy link
Contributor Author

@rghetia done signed the CLA

Thanks. There is a conflict in go.mod. Can you please rebase/resolve the conflict?

@rghetia done and checks passed

@rghetia rghetia changed the title fixes open-telemetry/opentelemetry-go#205 init go modules for jaeger exporter Oct 23, 2019
@krnowak
Copy link
Member

krnowak commented Oct 24, 2019

Looks good.

@rghetia rghetia merged commit 79c5fd7 into open-telemetry:master Oct 24, 2019
hstan referenced this pull request in hstan/opentelemetry-go Oct 15, 2020
@connorlindsey @MrAlias
Cortex: Add support for histogram and distribution (#237)
453f28e 
* Cortex: Add support for histogram and distribution

* Cortex: Switch to HistogramDistribution Processor

* Update exporters/metric/cortex/cortex.go

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>

* Update exporters/metric/cortex/cortex.go

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>

* Update exporters/metric/cortex/cortex.go

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>

* Update exporters/metric/cortex/cortex.go

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>

* Fix comment and remove count map

* Make precommit

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
@pellared pellared added this to the untracked milestone Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rghetia rghetia rghetia approved these changes

@krnowak krnowak krnowak approved these changes

@bogdandrutu bogdandrutu Awaiting requested review from bogdandrutu

@jmacd jmacd Awaiting requested review from jmacd

@pjanotti pjanotti Awaiting requested review from pjanotti

@sjkaris sjkaris Awaiting requested review from sjkaris

@tedsuo tedsuo Awaiting requested review from tedsuo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
untracked
Development

Successfully merging this pull request may close these issues.

Jaeger exporter should be its own go module
4 participants
@eran-levy @rghetia @krnowak @pellared