Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the Zipkin attribute names for the ot to otel #1201

Merged
merged 2 commits into from
Sep 24, 2020
Merged

Update the Zipkin attribute names for the ot to otel #1201

merged 2 commits into from
Sep 24, 2020

Conversation

danrusei
Copy link
Contributor

Update the attribute names for the OTel attributes for the zipkin exporter
Based on the spec change: open-telemetry/opentelemetry-specification#967

@codecov
Copy link

codecov bot commented Sep 23, 2020

Codecov Report

Merging #1201 into master will decrease coverage by 0.2%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #1201     +/-   ##
========================================
- Coverage    76.6%   76.4%   -0.3%     
========================================
  Files         134     134             
  Lines        5695    5723     +28     
========================================
+ Hits         4368    4373      +5     
- Misses       1082    1106     +24     
+ Partials      245     244      -1     
Impacted Files Coverage Δ
exporters/trace/zipkin/model.go 98.6% <ø> (ø)
sdk/export/metric/exportkind_string.go 66.6% <0.0%> (-33.4%) ⬇️
label/type_string.go 7.1% <0.0%> (-26.2%) ⬇️
api/metric/kind_string.go 10.0% <0.0%> (-23.4%) ⬇️
api/metric/numberkind_string.go 16.6% <0.0%> (-16.7%) ⬇️
api/trace/api.go 57.1% <0.0%> (ø)
api/global/internal/trace.go 88.8% <0.0%> (ø)
api/trace/noop_trace_provider.go 100.0% <0.0%> (ø)
semconv/http.go 95.3% <0.0%> (+<0.1%) ⬆️
sdk/trace/batch_span_processor.go 80.6% <0.0%> (+2.1%) ⬆️

Copy link
Member

@XSAM XSAM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

m["ot.status_code"] = data.StatusCode.String()
m["ot.status_description"] = data.StatusMessage

Should we update these names too?

@danrusei
Copy link
Contributor Author

m["ot.status_code"] = data.StatusCode.String()
m["ot.status_description"] = data.StatusMessage

Should we update these names too?

Thank you for pointing that out, will do.

Copy link
Member

@XSAM XSAM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for your contribution.

@Aneurysm9 Aneurysm9 merged commit 559fecd into open-telemetry:master Sep 24, 2020
@danrusei danrusei deleted the zipkin_attr_from_OT_to_OTel branch October 1, 2020 07:45
@pellared pellared added this to the untracked milestone Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants