-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the Zipkin attribute names for the ot to otel #1201
Update the Zipkin attribute names for the ot to otel #1201
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1201 +/- ##
========================================
- Coverage 76.6% 76.4% -0.3%
========================================
Files 134 134
Lines 5695 5723 +28
========================================
+ Hits 4368 4373 +5
- Misses 1082 1106 +24
+ Partials 245 244 -1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
opentelemetry-go/exporters/trace/zipkin/model.go
Lines 156 to 157 in 817a1d0
m["ot.status_code"] = data.StatusCode.String() | |
m["ot.status_description"] = data.StatusMessage |
Should we update these names too?
Thank you for pointing that out, will do. |
…orter Based on the spec change: open-telemetry/opentelemetry-specification#967
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for your contribution.
Update the attribute names for the OTel attributes for the zipkin exporter
Based on the spec change: open-telemetry/opentelemetry-specification#967