Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename prefix for Zipkin attributes from OT to OTel #967

Merged
merged 1 commit into from
Sep 21, 2020
Merged

Rename prefix for Zipkin attributes from OT to OTel #967

merged 1 commit into from
Sep 21, 2020

Conversation

anuraaga
Copy link
Contributor

The official rename of the acronym happened after this spec was made, but looks like we haven't updated it yet.

@anuraaga anuraaga requested review from a team September 18, 2020 04:05
@anuraaga anuraaga mentioned this pull request Sep 18, 2020
Merged
3 tasks
@Oberon00
Copy link
Member

We should really standardize these attribute names across different exporters #660 (comment)

@anuraaga
Copy link
Contributor Author

Yeah definitely - I see work like open-telemetry/opentelemetry-python#1124 but should we block work on exporters until the attributes are finalized?

@Oberon00
Copy link
Member

No, I don't think that is required, as long as we take care to be consistent even without a central definition.

@Oberon00
Copy link
Member

I just did not approve because I have no idea about zipkin 😄

tigrannajaryan
tigrannajaryan approved these changes Sep 18, 2020
View reviewed changes
Copy link
Member

@tigrannajaryan tigrannajaryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should specify somewhere that "otel.*" is reserved for OpenTelemetry usage and should not be used for any other semantic conventions or attribute names. This is to ensure there are no clashes if the end users decide for some reason to prefix their own attributes with "otel.".

Can be done in a separate PR.

@bogdandrutu bogdandrutu merged commit 3ba5b5a into open-telemetry:master Sep 21, 2020
@jtescher jtescher mentioned this pull request Sep 21, 2020
Closed
@jkwatson jkwatson mentioned this pull request Sep 21, 2020
Closed
@danrusei danrusei mentioned this pull request Sep 23, 2020
Merged
Aneurysm9 pushed a commit to open-telemetry/opentelemetry-go that referenced this pull request Sep 24, 2020
@danrusei
Update the attribute names for the OTel attributes for the zipkin exp…
559fecd 
…orter (#1201)

Based on the spec change: open-telemetry/opentelemetry-specification#967
shbieng added a commit to shbieng/opentelemetry-go that referenced this pull request Aug 26, 2022
@shbieng
Update the attribute names for the OTel attributes for the zipkin exp…
3a3ecc6 
…orter (#1201)

Based on the spec change: open-telemetry/opentelemetry-specification#967
carlosalberto pushed a commit to carlosalberto/opentelemetry-specification that referenced this pull request Oct 31, 2024
Rename prefix for Zipkin attributes from OT to OTel (open-telemetry#967)
4a6d363
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arminru arminru arminru approved these changes

@tigrannajaryan tigrannajaryan tigrannajaryan approved these changes

@iNikem iNikem iNikem approved these changes

@bogdandrutu bogdandrutu bogdandrutu approved these changes

@carlosalberto carlosalberto carlosalberto approved these changes

@codeboten codeboten codeboten approved these changes

Assignees

@bogdandrutu bogdandrutu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@anuraaga @Oberon00 @codeboten @carlosalberto @bogdandrutu @iNikem @tigrannajaryan @arminru