Move metric api package into otel
#1252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrAlias
added
pkg:API
MrAlias
requested review from
Aneurysm9,
evantorrie,
jmacd,
lizthegrey and
XSAM
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1252 +/- ##
========================================
- Coverage 76.9% 76.8% -0.1%
========================================
Files 132 122 -10
Lines 5925 5924 -1
========================================
- Hits 4558 4553 -5
- Misses 1120 1125 +5
+ Partials 247 246 -1
|
jmacd
approved these changes
Oct 16, 2020
XSAM
approved these changes
Oct 17, 2020
Merged
AzfaarQureshi
pushed a commit
to open-o11y/opentelemetry-go
that referenced
this pull request
Dec 3, 2020
* Update metric Kind to InstrumentKind * Update all the other modules with Kind rename * Update metric Descriptor with instrument Kind rename * Update other modules with Descriptor method rename * Update OTLP exporter test field name * Rename kind filenames * Add changes to CHANGELOG * Fix documentation for Grouping and PrecomputedSum * Rename meter.go to metric.go * Move descriptor.go into metric.go * Move must.go into metric.go * Move instruments into metric_instrument.go * Rename metric api_test.go to metric_test.go * Move instrumentkind_test.go into metric_test.go * Rename sdkapi.go metric_sdkapi.go * Move api/metric into otel * Update to use moved packages * Rename otel.go to error_handler.go * Add changes to CHANGELOG * Fix merge conflict resolution error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
api/metricpackage intootelas part of Move OpenTelemetry API to top level go.opentelemetry.io/otel package #964api/metric/metrictestpackage intootelas part of Move OpenTelemetry API to top level go.opentelemetry.io/otel package #964api/metric/registrypackage intootelas part of Move OpenTelemetry API to top level go.opentelemetry.io/otel package #964WithInstrumentationVersionoption to work for Tracers, Meters, and Instruments instead of breaking apart into multiple functions.