Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the otel/api/global package to otel/global #1262

Merged
merged 5 commits into from
Oct 17, 2020

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Oct 16, 2020

This will be the final part of #964 if merged after #1252, moving the api package to otel so the entry point for use is clear.

Resolves #964

@MrAlias MrAlias added pkg:API Related to an API package release:required-for-ga labels Oct 16, 2020
@MrAlias MrAlias added this to the RC1 milestone Oct 16, 2020
@MrAlias MrAlias self-assigned this Oct 16, 2020
@codecov
Copy link

codecov bot commented Oct 16, 2020

Codecov Report

Merging #1262 into master will decrease coverage by 0.5%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #1262     +/-   ##
========================================
- Coverage    76.9%   76.4%   -0.6%     
========================================
  Files         122     132     +10     
  Lines        5924    5926      +2     
========================================
- Hits         4557    4528     -29     
- Misses       1120    1147     +27     
- Partials      247     251      +4     
Impacted Files Coverage Δ
bridge/opentracing/bridge.go 40.0% <ø> (+0.9%) ⬆️
exporters/metric/prometheus/prometheus.go 54.5% <ø> (ø)
exporters/stdout/exporter.go 25.9% <ø> (ø)
exporters/trace/jaeger/env.go 100.0% <ø> (ø)
exporters/trace/jaeger/jaeger.go 84.6% <ø> (ø)
exporters/trace/zipkin/zipkin.go 73.0% <ø> (ø)
global/handler.go 73.3% <ø> (ø)
global/internal/meter.go 90.3% <ø> (ø)
global/internal/propagator.go 10.5% <ø> (ø)
global/internal/state.go 70.2% <ø> (ø)
... and 49 more

@MrAlias MrAlias merged commit d6dd84f into open-telemetry:master Oct 17, 2020
@MrAlias MrAlias deleted the mv-global branch October 17, 2020 17:04
@MrAlias MrAlias mentioned this pull request Nov 20, 2020
AzfaarQureshi pushed a commit to open-o11y/opentelemetry-go that referenced this pull request Dec 3, 2020
* Move otel/api/global to otel/global

* Update global package references

* Add changes to CHANGELOG
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:API Related to an API package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move OpenTelemetry API to top level go.opentelemetry.io/otel package
3 participants