Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old OTLP exporter #1990

Merged
merged 5 commits into from
Jun 11, 2021

Conversation

Aneurysm9
Copy link
Member

No description provided.

Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com>
Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com>
Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com>
@codecov
Copy link

codecov bot commented Jun 10, 2021

Codecov Report

Merging #1990 (cef95b9) into main (7728a52) will decrease coverage by 1.9%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #1990     +/-   ##
=======================================
- Coverage   77.3%   75.3%   -2.0%     
=======================================
  Files        162     143     -19     
  Lines       8495    6896   -1599     
=======================================
- Hits        6567    5194   -1373     
+ Misses      1678    1495    -183     
+ Partials     250     207     -43     
Impacted Files Coverage Δ
sdk/metric/refcount_mapped.go 77.7% <0.0%> (-22.3%) ⬇️
sdk/metric/sdk.go 80.2% <0.0%> (-1.2%) ⬇️

Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com>
@Aneurysm9 Aneurysm9 changed the title Remove trace export support from old OTLP exporter Remove old OTLP exporter Jun 11, 2021
@Aneurysm9 Aneurysm9 merged commit 64b640c into open-telemetry:main Jun 11, 2021
@Aneurysm9 Aneurysm9 deleted the remove_old_otlp_trace branch June 11, 2021 15:18
@tonistiigi
Copy link
Contributor

Was it expected that this removed support for http/json that is not part of #1963? I don't see this mentioned in the changelog and according to #1122 it is a spec requirement.

@MrAlias
Copy link
Contributor

MrAlias commented Jun 21, 2021

Was it expected that this removed support for http/json that is not part of #1963? I don't see this mentioned in the changelog and according to #1122 it is a spec requirement.

It was. You can find more context here: #1924

Regarding the specification, the stable release that we are implementing ended up only requiring one of the three listed protocol/transport pairs. We dropped support for HTTP/JSON because our implementation was incorrect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants