Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add otlp trace http exporter #1963

Merged
merged 5 commits into from
Jun 7, 2021
Merged

add otlp trace http exporter #1963

merged 5 commits into from
Jun 7, 2021

Conversation

paivagustavo
Copy link
Member

Follow up from #1922.

This implements a HTTP otlptrace.Client.

Next steps

This is part of the #1827 todo list:

  • add gRPC otlp trace exporter
  • add HTTP otlp trace exporter
  • add gRPC otlp metrics exporter
  • add HTTP otlp metrics exporter
  • refactor out the duplicated code (transform, connection, otlpconfig)
  • update examples and remove old otlp gRPC/HTTP exporter
  • update docs

@codecov
Copy link

codecov bot commented May 27, 2021

Codecov Report

Merging #1963 (adb0d3f) into main (a75ade4) will increase coverage by 0.2%.
The diff coverage is 90.9%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #1963     +/-   ##
=======================================
+ Coverage   76.3%   76.5%   +0.2%     
=======================================
  Files        157     160      +3     
  Lines       8363    8495    +132     
=======================================
+ Hits        6385    6505    +120     
- Misses      1723    1732      +9     
- Partials     255     258      +3     
Impacted Files Coverage Δ
...ters/otlp/otlptrace/internal/otlpconfig/options.go 75.6% <ø> (ø)
exporters/otlp/otlptrace/otlptracehttp/exporter.go 0.0% <0.0%> (ø)
exporters/otlp/otlptrace/otlptracehttp/client.go 93.2% <93.2%> (ø)
exporters/otlp/otlptrace/otlptracehttp/options.go 100.0% <100.0%> (ø)

@MrAlias MrAlias added this to the RC1 milestone Jun 3, 2021
Copy link
Contributor

@MadVikingGod MadVikingGod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the Exported constants I think this is good to go.

exporters/otlp/otlptrace/otlptracehttp/client.go Outdated Show resolved Hide resolved
Copy link
Contributor

@MrAlias MrAlias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing blocking.

exporters/otlp/otlptrace/otlptracehttp/options.go Outdated Show resolved Hide resolved
exporters/otlp/otlptrace/otlptracehttp/options.go Outdated Show resolved Hide resolved
exporters/otlp/otlptrace/otlptracehttp/options.go Outdated Show resolved Hide resolved
exporters/otlp/otlptrace/otlptracehttp/options.go Outdated Show resolved Hide resolved
exporters/otlp/otlptrace/otlptracehttp/options.go Outdated Show resolved Hide resolved
Copy link
Member

@hanyuancheung hanyuancheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MrAlias MrAlias merged commit 2371bb0 into open-telemetry:main Jun 7, 2021
@Aneurysm9 Aneurysm9 mentioned this pull request Jun 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants