-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Verify and update OTLP trace exporter documentation #2053
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Submarinee
requested review from
Aneurysm9,
dashpole,
evantorrie,
jmacd,
MadVikingGod,
MrAlias,
paivagustavo,
pellared and
XSAM
as code owners
July 3, 2021 13:28
Submarinee
changed the title
Verify and update OTLP exporter documentation
Verify and update OTLP trace exporter documentation
Jul 4, 2021
pellared
reviewed
Jul 5, 2021
pellared
reviewed
Jul 6, 2021
Co-authored-by: Robert Pająk <pellared@hotmail.com>
Co-authored-by: Robert Pająk <pellared@hotmail.com>
MrAlias
reviewed
Jul 22, 2021
MrAlias
added
documentation
Provides helpful information
pkg:exporter:otlp
Related to the OTLP exporter package
labels
Jul 22, 2021
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
pellared
reviewed
Jul 30, 2021
Co-authored-by: Robert Pająk <pellared@hotmail.com>
pellared
reviewed
Jul 30, 2021
Co-authored-by: Robert Pająk <pellared@hotmail.com>
pellared
reviewed
Jul 30, 2021
Co-authored-by: Robert Pająk <pellared@hotmail.com>
MrAlias
approved these changes
Aug 17, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like an incremental improvement to the docs. Thanks for the contribution.
The suggestions are not blocking.
dashpole
reviewed
Aug 18, 2021
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
MrAlias
reviewed
Sep 2, 2021
This is the last PR blocking our next RC release. I'm going to see if I can push some code to move this along. |
pellared
approved these changes
Sep 2, 2021
MadVikingGod
approved these changes
Sep 2, 2021
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
Provides helpful information
pkg:exporter:otlp
Related to the OTLP exporter package
Skip Changelog
PRs that do not require a CHANGELOG.md entry
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially resolved issue #2016 .
I referred to changes related to OTLP trace exporter in #1827,#1832,#1922, #1963,#1985,#1991, #2013 and created a README about the changes.
BecauseI am a freshman in opentelemetry-go, maybe my PR is not good enough.
If you think I can improve in any aspect, please bring it up.
I am very willing to listen to your suggestions.
Thank u~
I will continue to inventory the documentation for OTLP metric exporter.