Propagate non-retryable error messages to client

[mark-pictor-csec]

PR #5541 (and issue #5536) enhance error handling, returning body text as part of the error. However, this is only done for retryable errors; if non-retryable, error text still does not propagate to clients.

This PR adds handling of non-retryable errors, ensuring any body text is part of the message returned to the user's code. There is no change to the circumstances under which errors are reported, just an enhancement of the content of such an error.

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: dmathieu / name: Damien Mathieu (4a2a799)
• ✅ login: mark-pictor-csec (6450b18, f24b300, a2220df, e3332de, ffa1610, 162afaa)

[dmathieu]

Aside from these errors, I noticed inconsistencies in the closing of the response body. For traces, the Close happened in a defer statement and any error was logged. Logs and metrics were less rigorous. It appeared Close() wasn't always called, and when it was, errors were returned sometimes and ignored at other times.

Could you split that into another PR?

You will need to sign the CLA.

[mark-pictor-csec]

Aside from these errors, I noticed inconsistencies in the closing of the response body. For traces, the Close happened in a defer statement and any error was logged. Logs and metrics were less rigorous. It appeared Close() wasn't always called, and when it was, errors were returned sometimes and ignored at other times.

Could you split that into another PR?

Can do.

You will need to sign the CLA.

Yes, I am waiting on someone within my company (corp CLA).

[mark-pictor-csec]

Converted to draft until I get the CLA issue resolved.
Now waiting on the body close PR #5954 since this depends upon it.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.6%. Comparing base (9b2e867) to head (4a2a799).
Report is 1 commits behind head on main.

Additional details and impacted files

@@          Coverage Diff          @@
##            main   #5929   +/-   ##
=====================================
  Coverage   84.6%   84.6%           
=====================================
  Files        272     272           
  Lines      22897   22883   -14     
=====================================
- Hits       19390   19380   -10     
+ Misses      3163    3158    -5     
- Partials     344     345    +1     

see 5 files with indirect coverage changes

---- 🚨 Try these New Features:

• Flaky Tests Detection - Detect and resolve failed and flaky tests

[mark-pictor-csec]

@dmathieu CLA signed and the PR split from this is merged. Shall I create a new PR or are we good to go with this one?

[pellared]

we good to go with this one?

We are good with this one.