Implement Metrics incubator APIs to accept advice #1190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Feature addition - Adds support for OTel Metrics APIs to support explicit bucket boundaries advice which is translated as service level objectives in Micrometer distribution summaries.
Feature addition - Adds support for OTel Metrics incubator API to support advice to filter the attributes used as metrics dimensions. This is necessary to be used with OTel Instrumentation which relies on attributes advice to filter out high-cardinality attributes.
Existing Issue(s):
N/A
Testing:
Unit testing complete. Integration tests TBD.
Documentation:
TBD
Outstanding items:
Need to add documentation.