Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable http and rpc metrics when advice can not be applied #10671

Merged
merged 1 commit into from
Feb 27, 2024

Conversation

laurit
Copy link
Contributor

@laurit laurit commented Feb 26, 2024

When advice can not be applied then most likely we'll end up with high cardinality metrics. This situation can arise because of bugs in other projects trinodb/trino#20074 that we can't do much about and also because of bugs in projects open-telemetry/opentelemetry-java-contrib#1190 where we could fix it.

@laurit laurit requested a review from a team February 26, 2024 14:10
@laurit laurit merged commit e67d73e into open-telemetry:main Feb 27, 2024
49 checks passed
@laurit laurit deleted the disable-metrics-without-advice branch February 27, 2024 09:35
@gaeljw
Copy link

gaeljw commented Mar 13, 2024

I hadn't noticed this PR. Thanks for the work. It will indeed help to "workaround" trinodb/trino#20074.

@laurit
Copy link
Contributor Author

laurit commented Mar 13, 2024

I hadn't noticed this PR. Thanks for the work. It will indeed help to "workaround" trinodb/trino#20074.

Note that for this to work trino would need to use a version of the instrumentation-api that contains this change. As they seem to update dependencies this should eventually happen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants