Use byte-buddy-dep instead of byte-buddy #4400
Conversation
laurit
requested review from
anuraaga,
iNikem,
jkwatson,
mateuszrzeszutek,
pavolloffay,
trask and
tylerbenson
as code owners
| - name: Local publish gradle plugin | ||
| run: ../gradlew publishToMavenLocal -x javadoc | ||
| working-directory: gradle-plugins | ||
|
|
There was a problem hiding this comment.
I think this won't be needed now that I finally got #4248 working
There was a problem hiding this comment.
I'll remove this and the same in pr.yml when #4248 is merged
There was a problem hiding this comment.
👍 going to merge this PR since #4248 is getting reworked, and I'll take care of it in that PR
gradle-plugins/build.gradle.kts
Outdated
|
|
||
| val extractBbGradlePlugin by registering(Copy::class) { | ||
| from(zipTree(bbGradlePlugin.files.first { it.name.contains("byte-buddy-gradle-plugin") })) { |
There was a problem hiding this comment.
Honestly, this looks like a hack. Why exactly do we need to unzip a dependency jar file into our classes folder instead of putting jar file to a classpath?
There was a problem hiding this comment.
Thanks for pointing this out. I think I figured out how to get rid of this.
There was a problem hiding this comment.
To answer your other question we could use SerialVersionUIDAdder for virtual field implementation which is in javaagent-tooling but so is io.opentelemetry.javaagent.tooling.muzzle.generation.MuzzleCodeGenerator which, as far as I can tell, is the actual class that does the work for gradle plugin.
Instead of replacing byte-buddy with byte-buddy-dep we could copy SerialVersionUIDAdder class from asm or we could shade our own copy of asm-commons that includes all classes under the same package as bytebuddy uses. I went for replacing byte-buddy with byte-buddy-dep because in my opinion this gives us the clearest path forward in case we need to include more asm classes.
It's needed in the runtime -- we'll want to use it in the |
laurit
force-pushed
the
byte-buddy-dep
branch
from
82a1abd to
05ee3b9
Compare
* Use byte-buddy-dep instead of byte-buddy * print stacktrace on examples failure * try to fix gradle plugins * try to fix extension build * try to fix extension build * try to fix extension build * try to fix extension build * try removing mavenLocal * add mavenLocal plugin repository * publish gradle-plugins to mavenLocal for examples ci build * Fix bytebuddy exclusion
Replaces
byte-buddywhich includes shaded asm with byte-buddy-dep that just depends on asm. As byte-buddy includes only the asm classes it needs it is missing some that we might need. For example for #4370 we needSerialVersionUIDAdderwhich is not included in byte-buddy.