Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NH-10600: Upgrade otel agent dependencies #36

Merged
merged 8 commits into from
Apr 20, 2022
Merged

Conversation

ghost
Copy link
Contributor

@ghost ghost commented Apr 5, 2022

This PR upgrades the Otel agent from v1.7.2 to v1.12.1. As a side affect, it also reduces the size of our agent.
Ref:
open-telemetry/opentelemetry-java-instrumentation#4400 (updated byte buddy dependencies)

The agent size is reduced from about 50 MB to 25MB due to the following changes:

  • upgraded the Otel agent dependency which removes some large dependencies (gRPC, netty)
  • changed a dependency type in one of the instrumentation modules and removed class files duplicates
  • removed javassist from Joboe dependencies lib as we no longer need javassist to do the bytecode injection (https://github.com/librato/joboe/pull/1540)

Another small improvement is that the build artifact is changed from solarwinds-apm-agent-all.jar to solarwinds-apm-agent.jar.

Repository owner marked this pull request as ready for review April 7, 2022 22:05
Repository owner requested a review from malin-olafson_swi April 19, 2022 23:18
@ghost
Copy link
Contributor Author

ghost commented Apr 19, 2022

Copy link
Mannequin

@malin-olafson_swi malin-olafson_swi mannequin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Repository owner merged commit 8f8c7a8 into main Apr 20, 2022
Repository owner deleted the NH-10600-shrink-size branch April 20, 2022 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants