Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change rpc type in apache dubbo #5432

Merged
merged 4 commits into from
Apr 1, 2022
Merged

change rpc type in apache dubbo #5432

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
34c1325
change rpc type in apache dubbo
tydhot Feb 23, 2022
8f21f62
fix dubbo test
tydhot Feb 24, 2022
a3659b8
Merge branch 'main' of https://github.com/open-telemetry/opentelemetr…
tydhot Mar 31, 2022
5d93d66
fix test
tydhot Mar 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...main/java/io/opentelemetry/instrumentation/apachedubbo/v2_7/DubboRpcAttributesGetter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ enum DubboRpcAttributesGetter implements RpcAttributesGetter<DubboRequest> {

@Override
public String system(DubboRequest request) {
return "dubbo";
return "apache_dubbo";
}

@Override
Expand Down
8 changes: 4 additions & 4 deletions ...rc/main/groovy/io/opentelemetry/instrumentation/apachedubbo/v2_7/AbstractDubboTest.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ abstract class AbstractDubboTest extends InstrumentationSpecification {
kind CLIENT
childOf span(0)
attributes {
"$SemanticAttributes.RPC_SYSTEM" "dubbo"
"$SemanticAttributes.RPC_SYSTEM" "apache_dubbo"
"$SemanticAttributes.RPC_SERVICE" "org.apache.dubbo.rpc.service.GenericService"
"$SemanticAttributes.RPC_METHOD" "\$invoke"
"$SemanticAttributes.NET_PEER_NAME" "localhost"
Expand All @@ -109,7 +109,7 @@ abstract class AbstractDubboTest extends InstrumentationSpecification {
kind SERVER
childOf span(1)
attributes {
"$SemanticAttributes.RPC_SYSTEM" "dubbo"
"$SemanticAttributes.RPC_SYSTEM" "apache_dubbo"
"$SemanticAttributes.RPC_SERVICE" "io.opentelemetry.instrumentation.apachedubbo.v2_7.api.HelloService"
"$SemanticAttributes.RPC_METHOD" "hello"
"$SemanticAttributes.NET_PEER_IP" String
Expand Down Expand Up @@ -168,7 +168,7 @@ abstract class AbstractDubboTest extends InstrumentationSpecification {
kind CLIENT
childOf span(0)
attributes {
"$SemanticAttributes.RPC_SYSTEM" "dubbo"
"$SemanticAttributes.RPC_SYSTEM" "apache_dubbo"
"$SemanticAttributes.RPC_SERVICE" "org.apache.dubbo.rpc.service.GenericService"
"$SemanticAttributes.RPC_METHOD" "\$invokeAsync"
"$SemanticAttributes.NET_PEER_NAME" "localhost"
Expand All @@ -180,7 +180,7 @@ abstract class AbstractDubboTest extends InstrumentationSpecification {
kind SERVER
childOf span(1)
attributes {
"$SemanticAttributes.RPC_SYSTEM" "dubbo"
"$SemanticAttributes.RPC_SYSTEM" "apache_dubbo"
"$SemanticAttributes.RPC_SERVICE" "io.opentelemetry.instrumentation.apachedubbo.v2_7.api.HelloService"
"$SemanticAttributes.RPC_METHOD" "hello"
"$SemanticAttributes.NET_PEER_IP" String
Expand Down