Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change rpc type in apache dubbo #5432

Merged
merged 4 commits into from
Apr 1, 2022
Merged

change rpc type in apache dubbo #5432

merged 4 commits into from
Apr 1, 2022

Conversation

tydhot
Copy link
Member

@tydhot tydhot commented Feb 23, 2022

At present, many users' old systems in China are using Alibaba Dubbo. RPC types here need to be distinguished, otherwise there will be some confusion in observation.
Alibaba dubbo: https://search.maven.org/search?q=a:dubbo

@tydhot tydhot requested a review from a team February 23, 2022 14:13
trask
trask reviewed Feb 23, 2022
View reviewed changes
Copy link
Member

@trask trask left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @tydhot! let's try to get this into the specification

I just opened open-telemetry/opentelemetry-specification#2377 to start with. After that we can propose rpc.system values for Alibaba Dubbo and Apache Dubbo.

@tydhot
Copy link
Member Author

tydhot commented Feb 24, 2022

@trask thanks!

@trask
Copy link
Member

trask commented Mar 22, 2022

hi @tydhot, we can propose to specification now.

do you have a preference on naming?

https://github.com/open-telemetry/opentelemetry-specification/blob/057a1bc79f5cca85d0eebd0b5e5ec03c6a36cf7a/semantic_conventions/trace/rpc.yaml#L7-L21

maybe?

            - id: apache_dubbo
              value: 'apache_dubbo'
              brief: 'Apache Dubbo'
            - id: `alibaba_dubbo`
              value: 'alibaba_dubbo'
              brief: 'Alibaba Dubbo'

@tydhot
Copy link
Member Author

tydhot commented Mar 28, 2022

@trask

I think that's it. No problem :)

@trask trask mentioned this pull request Mar 29, 2022
Merged
trask
trask approved these changes Mar 31, 2022
View reviewed changes
Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx @tydhot!

@laurit laurit merged commit f269ef7 into open-telemetry:main Apr 1, 2022
RashmiRam pushed a commit to RashmiRam/opentelemetry-auto-instr-java that referenced this pull request May 23, 2022
@tydhot @RashmiRam
change rpc type in apache dubbo (open-telemetry#5432)
fed50dd 
* change rpc type in apache dubbo

* fix dubbo test

* fix test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laurit laurit laurit approved these changes

@trask trask trask approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tydhot @trask @laurit