Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NPE happening when .headersWhen() is used (reactor-netty) #9511

Merged
merged 2 commits into from
Sep 21, 2023
Merged

Fix NPE happening when .headersWhen() is used (reactor-netty) #9511

merged 2 commits into from
Sep 21, 2023

Conversation

mateuszrzeszutek
Copy link
Member

Fixes #9499

@mateuszrzeszutek mateuszrzeszutek requested a review from a team September 20, 2023 10:54
@mateuszrzeszutek
Copy link
Member Author

mateuszrzeszutek commented Sep 20, 2023 •
edited
Loading

I also filed a reactor-netty bug for that: reactor/reactor-netty#2904
I think it's weird that some callback functions are not called at all when you use deferred config.

@mateuszrzeszutek mateuszrzeszutek force-pushed the reactor-netty-headersWhen branch from 4674c83 to 21140e7 Compare September 20, 2023 12:20
@trask trask merged commit 7bbd7a4 into open-telemetry:main Sep 21, 2023
45 checks passed
@mateuszrzeszutek mateuszrzeszutek deleted the reactor-netty-headersWhen branch September 22, 2023 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trask trask trask approved these changes

@laurit laurit laurit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NullPointerException from reactornetty instrumentation introduced in version 1.29.0
3 participants
@mateuszrzeszutek @trask @laurit