You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I would expect that the HTTP client executes its callbacks regardless of whether the headers were set using .headersWhen() or headers(). Currently this is not the case, .mapConnect() and .doOnRequestError() callbacks are not executed when deferred config is used.
Actual Behavior
.mapConnect() and .doOnRequestError() callbacks are not executed when deferred config is used.
Hey @violetagg ,
I'll need to make sure with my employer that I can sign the CLA -- it might take me a while, so unfortunately don't count on a quick fix from me.
Expected Behavior
I would expect that the HTTP client executes its callbacks regardless of whether the headers were set using
.headersWhen()
orheaders()
. Currently this is not the case,.mapConnect()
and.doOnRequestError()
callbacks are not executed when deferred config is used.Actual Behavior
.mapConnect()
and.doOnRequestError()
callbacks are not executed when deferred config is used.Steps to Reproduce
This test prints out the two messages to stdout:
This one does not:
Possible Solution
reactor-netty/reactor-netty-http/src/main/java/reactor/netty/http/client/HttpClientConnect.java
Lines 111 to 118 in c7ba195
Removing the
return
in line 113 would allow the code in lines 120-133reactor-netty/reactor-netty-http/src/main/java/reactor/netty/http/client/HttpClientConnect.java
Lines 120 to 133 in c7ba195
Mono
is returned.Your Environment
netty
, ...):java -version
): OpenJDK Runtime Environment Temurin-17.0.2+8 (build 17.0.2+8)uname -a
): Darwin Kernel Version 22.6.0The text was updated successfully, but these errors were encountered: