Skip to content

Commit

Permalink
Remove the finalizer on the RecordEventsReadableSpan. (#1083)
Browse files Browse the repository at this point in the history
  • Loading branch information
jkwatson authored Apr 6, 2020
1 parent 892af36 commit de7de59
Showing 1 changed file with 0 additions and 11 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -516,15 +516,4 @@ private RecordEventsReadableSpan(
this.maxNumberOfAttributes = traceConfig.getMaxNumberOfAttributes();
this.maxNumberOfAttributesPerEvent = traceConfig.getMaxNumberOfAttributesPerEvent();
}

@SuppressWarnings("NoFinalizer")
@Override
protected void finalize() throws Throwable {
synchronized (lock) {
if (!hasEnded) {
logger.log(Level.SEVERE, "Span " + name + " is GC'ed without being ended.");
}
}
super.finalize();
}
}

0 comments on commit de7de59

Please sign in to comment.