Remove the finalizer on the RecordEventsReadableSpan. #1083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkwatson
requested review from
arminru,
bogdandrutu,
carlosalberto,
pavolloffay,
songy23 and
tylerbenson
as code owners
bogdandrutu
approved these changes
Apr 6, 2020
Codecov Report
@@ Coverage Diff @@
## master #1083 +/- ##
============================================
- Coverage 85.61% 85.58% -0.03%
+ Complexity 1087 1085 -2
============================================
Files 138 138
Lines 3996 3990 -6
Branches 356 355 -1
============================================
- Hits 3421 3415 -6
Misses 434 434
Partials 141 141
Continue to review full report at Codecov.
|
carlosalberto
approved these changes
Apr 6, 2020
davebarda
pushed a commit
to davebarda/opentelemetry-java
that referenced
this pull request
Apr 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #1074