Change otlp http/protobuf default port from 4317 to 4318 #3694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jack-berg
requested review from
anuraaga,
arminru,
bogdandrutu,
carlosalberto and
jkwatson
as code owners
jack-berg
requested review from
Oberon00,
pavolloffay,
thisthat and
tylerbenson
as code owners
|
I would have sworn I already did this PR, but it appears not. Perhaps I am going mad. |
This was referenced Dec 19, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To reflect updates to the spec.
The flip flopping is unfortunate, but luckily the collectors behavior still defaults to 4318 for http so I think its rather unlikely anyone has dependencies on the previous 4317 default.