Clarify OTEL_EXPORTER_OTLP_ENDPOINT envvar for OTLP/HTTP. #1975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oberon00
changed the title
Oberon00
commented
Sep 28, 2021
carlosalberto
approved these changes
Sep 28, 2021
fbogsany
reviewed
Sep 29, 2021
tigrannajaryan
approved these changes
Sep 29, 2021
There was a problem hiding this comment.
LGTM, once duplicate mycollector/ that @fbogsany noticed is fixed.
arminru
approved these changes
Sep 30, 2021
Co-authored-by: Francis Bogsanyi <francis.bogsanyi@shopify.com>
…-envvar Conflicts: specification/protocol/exporter.md
Oberon00
commented
Sep 30, 2021
Oberon00
commented
Sep 30, 2021
fbogsany
approved these changes
Sep 30, 2021
|
@iNikem Any further comment? Or are you ok with the current PR? |
anuraaga
approved these changes
Oct 4, 2021
iNikem
approved these changes
Oct 4, 2021
tigrannajaryan
pushed a commit
that referenced
this pull request
Oct 12, 2021
Clarifies that default ports for the URL schemes, not default OTLP/HTTP port should be used if no port is given in URL. See #1975 (comment)
tigrannajaryan
pushed a commit
to tigrannajaryan/opentelemetry-proto
that referenced
this pull request
Apr 20, 2023
Clarifies that default ports for the URL schemes, not default OTLP/HTTP port should be used if no port is given in URL. See open-telemetry/opentelemetry-specification#1975 (comment)
joaopgrassi
pushed a commit
to dynatrace-oss-contrib/semantic-conventions
that referenced
this pull request
Mar 21, 2024
Clarifies that default ports for the URL schemes, not default OTLP/HTTP port should be used if no port is given in URL. See open-telemetry/opentelemetry-specification#1975 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current wording of the OTLP endpoint config was confusing, especially the "if not present already" wording. Instead, clarify that we must always append when using the envvar for all signals (it was already clearly specified that the per-signal vars do not get the path appended).
This came up in open-telemetry/opentelemetry-java#3650 and again at open-telemetry/opentelemetry-java#3666 (comment).
Also make it a MUST (not SHOULD) since this kind of thing would be extremely annoying to have differences per-language in. Also, without appending, the variable cannot be used to configure more than one signal which would defeat its sole purpose.