-
Notifications
You must be signed in to change notification settings - Fork 849
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Sampler configuration factory #5763
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #5763 +/- ##
============================================
- Coverage 91.37% 91.36% -0.01%
- Complexity 5208 5214 +6
============================================
Files 582 582
Lines 15417 15449 +32
Branches 1479 1488 +9
============================================
+ Hits 14087 14115 +28
Misses 915 915
- Partials 415 419 +4
☔ View full report in Codecov by Sentry. |
static <T> T addAndReturn(List<Closeable> closeables, T closeable) { | ||
if (closeable instanceof Closeable) { | ||
closeables.add((Closeable) closeable); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is that because the Jaeger sampler is Closeable
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes
Builds on #5751, #5687, #5399, #5757, #5758 by adding logic to interpret the sampler portion of configuration schema.