Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meter provider configuration factory #5773

Merged

Conversation

jack-berg
Copy link
Member

Builds on #5751, #5687, #5399, #5757, #5758, #5763, #5771 by adding logic to interpret the meter provider.

@jack-berg jack-berg requested a review from a team August 25, 2023 20:17
@codecov
Copy link

codecov bot commented Aug 25, 2023

Codecov Report

Patch coverage: 93.00% and project coverage change: +0.03% 🎉

Comparison is base (2deb6d1) 91.29% compared to head (1197816) 91.33%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5773      +/-   ##
============================================
+ Coverage     91.29%   91.33%   +0.03%     
- Complexity     5257     5334      +77     
============================================
  Files           586      592       +6     
  Lines         15618    15811     +193     
  Branches       1519     1564      +45     
============================================
+ Hits          14259    14441     +182     
- Misses          932      938       +6     
- Partials        427      432       +5     
Files Changed Coverage Δ
...ion/incubator/fileconfig/MeterProviderFactory.java 85.00% <85.00%> (ø)
...sion/incubator/fileconfig/MetricReaderFactory.java 86.84% <86.84%> (ø)
...ncubator/fileconfig/InstrumentSelectorFactory.java 86.95% <86.95%> (ø)
...nsion/incubator/fileconfig/AggregationFactory.java 87.50% <87.50%> (ø)
...on/incubator/fileconfig/MetricExporterFactory.java 95.91% <95.91%> (ø)
...emetry/exporter/logging/LoggingMetricExporter.java 83.33% <100.00%> (+0.57%) ⬆️
...elemetry/exporter/logging/LoggingSpanExporter.java 95.23% <100.00%> (+0.11%) ⬆️
...y/exporter/logging/SystemOutLogRecordExporter.java 93.02% <100.00%> (+0.16%) ⬆️
...incubator/fileconfig/LogRecordExporterFactory.java 94.28% <100.00%> (+5.71%) ⬆️
.../fileconfig/OpenTelemetryConfigurationFactory.java 100.00% <100.00%> (ø)
... and 2 more

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jack-berg jack-berg merged commit 01503ef into open-telemetry:main Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants