Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: address webpack memory issue for browser tests #1264

Merged
merged 1 commit into from
Nov 1, 2022

Conversation

MSNev
Copy link
Contributor

@MSNev MSNev commented Oct 31, 2022

Which problem is this PR solving?

Short description of the changes

  • Make sure the same versions of webpack and karma-webpack are used for all packages

@codecov
Copy link

codecov bot commented Oct 31, 2022

Codecov Report

Merging #1264 (a20b094) into main (180b336) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1264   +/-   ##
=======================================
  Coverage   96.08%   96.08%           
=======================================
  Files          14       14           
  Lines         893      893           
  Branches      191      191           
=======================================
  Hits          858      858           
  Misses         35       35           
Impacted Files Coverage Δ
...umentation-user-interaction/src/instrumentation.ts 92.28% <ø> (ø)
...lugin-react-load/src/BaseOpenTelemetryComponent.ts 97.02% <ø> (ø)

@MSNev MSNev marked this pull request as ready for review October 31, 2022 22:12
@MSNev MSNev requested a review from a team October 31, 2022 22:12
Copy link
Member

@blumamir blumamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

.github/workflows/unit-test.yml Show resolved Hide resolved
@dyladan dyladan merged commit c7f08fe into open-telemetry:main Nov 1, 2022
@dyladan dyladan mentioned this pull request Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants