Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bring back browser extension #1152

Closed
wants to merge 21 commits into from

Conversation

svrnm
Copy link
Member

@svrnm svrnm commented Sep 5, 2022

Which problem is this PR solving?

This PR brings back the browser extension by fixing the build errors & updating dependencies and some, see #1101, #1110

Short description of the changes

  • Move extension back to packages
  • Update dependencies until npm run compile works again
  • Update some of the dependencies and words (e.g. move from "Collector Trace" to "OTLP HTTP" exporter, etc.)
  • Add some clean ups
  • Add myself as component owner
  • Add a server folder that contains instructions on how to run a collector behind a nginx for proper CORS headers.

Signed-off-by: svrnm <neumanns@cisco.com>
@svrnm svrnm requested a review from a team September 5, 2022 15:54
@codecov
Copy link

codecov bot commented Sep 5, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.13%. Comparing base (dfb2dff) to head (6118091).
Report is 162 commits behind head on main.

Current head 6118091 differs from pull request most recent head 8006737

Please upload reports for the commit 8006737 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1152      +/-   ##
==========================================
+ Coverage   90.97%   96.13%   +5.15%     
==========================================
  Files         146       14     -132     
  Lines        7492      906    -6586     
  Branches     1502      197    -1305     
==========================================
- Hits         6816      871    -5945     
+ Misses        676       35     -641     

see 134 files with indirect coverage changes

@svrnm
Copy link
Member Author

svrnm commented Sep 6, 2022

not sure how to fix the issues with node 8 & node 10. Best option would be to exclude them, since the final runtime is the browser and the testing doesn't need to run on all node versions.

@vmarchaud vmarchaud requested a review from dyladan September 15, 2022 07:57
@dyladan
Copy link
Member

dyladan commented Sep 16, 2022

Failure appears to be a dependency conflict due to webpack versioning differences with other packages in the repo

@svrnm
Copy link
Member Author

svrnm commented Sep 19, 2022

Failure appears to be a dependency conflict due to webpack versioning differences with other packages in the repo

looks like I still have to learn about lerna and stuff... let me see if I can get this working somehow, because updating to a more recent version of webpack did the trick to get it compiled again, and downgrading sends me into a rabbit hole of dependency issues.

@blumamir
Copy link
Member

blumamir commented Nov 9, 2022

@MSNev aligned the webpack versions in #1264
Maybe rebasing main will fix the CI?

@blumamir
Copy link
Member

blumamir commented Nov 9, 2022

Also related - renovate's #1258 and #1123

Might be a good chance to upgrade these as well while we are at it, if you can

@@ -26,60 +27,62 @@
"node": ">=14"
},
"peerDependencies": {
"@opentelemetry/api": "^1.0.0"
"@opentelemetry/api": "^1.2.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why upgrade the "@opentelemetry/api" minimum supported minor versions?

If the user is using an older version of the API, will it fail to work?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why I changed it, it should work with 1.0 as well

@github-actions
Copy link
Contributor

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the stale label Aug 14, 2023
@SimenB
Copy link
Contributor

SimenB commented Aug 21, 2023

Still interesting in seeing this land 😀 anything I can do to help it along? #1486? it was closed without attention…

@github-actions github-actions bot removed the stale label Aug 28, 2023
@svrnm
Copy link
Member Author

svrnm commented Aug 31, 2023

Still interesting in seeing this land 😀 anything I can do to help it along? #1486? it was closed without attention…

Hey @SimenB, thanks for your interest in this! I was ooo the past few days and couldn't follow up. I think there are 2 options how to fix this, bumping webpack dependencies to 5. like in #1486 is the "better" solution, the other option is making the extension work differently (replace webpack with something else)

Copy link
Contributor

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the stale label Nov 20, 2023
@SimenB
Copy link
Contributor

SimenB commented Nov 20, 2023

Seems that other PR just needed webpack in order to work work with karma. Seeing as karma is deprecated, it might be better to just migrate to another test runner that doesn't webpack to begin with.

@svrnm
Copy link
Member Author

svrnm commented Nov 20, 2023

Seems that other PR just needed webpack in order to work work with karma. Seeing as karma is deprecated, it might be better to just migrate to another test runner that doesn't webpack to begin with.

wow, highly appreciated @SimenB !

@github-actions github-actions bot removed the stale label Nov 27, 2023
@JamieDanielson
Copy link
Member

Sorry on the delay on this. It's been several months since this was last updated, but @svrnm are you still interested in maintaining this? It seems like the blocker right now is to update web tests to use web-test-runner instead of karma. @SimenB already got the updated test runner in #1816 and there is an open PR with an error #2005.

We'll try to take a look at #2005 either way and as a follow-up will want to get the rest of the web components updated to use web-test-runner instead of karma. But still it will be useful to know if you are still interested in maintaining this or if it's no longer a need right now.

@svrnm
Copy link
Member Author

svrnm commented May 23, 2024

Sorry on the delay on this. It's been several months since this was last updated, but @svrnm are you still interested in maintaining this? It seems like the blocker right now is to update web tests to use web-test-runner instead of karma. @SimenB already got the updated test runner in #1816 and there is an open PR with an error #2005.

We'll try to take a look at #2005 either way and as a follow-up will want to get the rest of the web components updated to use web-test-runner instead of karma. But still it will be useful to know if you are still interested in maintaining this or if it's no longer a need right now.

I am happy to maintain this, if the tests are unblocked now, or if this requires me to rewrite the tests with web-test-runner instead of karma I can look into that.

@JamieDanielson
Copy link
Member

I am happy to maintain this, if the tests are unblocked now, or if this requires me to rewrite the tests with web-test-runner instead of karma I can look into that.

Ok thanks for the confirmation! On #2005 we seem to have found the cause of the errors on updating to use the new test runner, so we should be able to keep moving forward on those. If that's an area you're familiar with it's always useful to have your input or feedback on those changes 😃

We'll probably want to add a commit or otherwise kick the CI to see the latest on lint and test results.

@pichlermarc
Copy link
Member

We've hit some roadblocks with updating to @web/test-runner (missing named exports from the shimmer package, which don't play well with rollup), so I tried again to update webpack to v5 as we've done that in the core repo previously. Workflows are passing, so this might unblock this PR. See #2269

@pichlermarc
Copy link
Member

pichlermarc commented Jun 11, 2024

I just merged #2269. The outdated webpack version should now not be a problem anymore 🙂

@svrnm
Copy link
Member Author

svrnm commented Jun 11, 2024

That's great news, @pichlermarc! I'll look into it eventually to fix the extension

svrnm added 2 commits June 11, 2024 16:24
Signed-off-by: svrnm <neumanns@cisco.com>
Signed-off-by: svrnm <neumanns@cisco.com>
@svrnm
Copy link
Member Author

svrnm commented Jun 12, 2024

FYI, since the code hasn't been touched for that long it will take me some time to get everything back in place

@svrnm
Copy link
Member Author

svrnm commented Jun 17, 2024

Note, that after discussing this with @JamieDanielson and @pichlermarc I will not bring back this browser extension to reduce the maintenance burden for the maintainers and myself. Instead I work towards listing existing extensions (like https://github.com/tbrockman/opentelemetry-browser-extension) on the Registry and then link out to the registry via the README of the archived extension.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.