chore: update to webpack 5 #2269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
assigned basti1302, blumamir, dyladan, kirrg001, legendecas, martinkuba, obecny and pichlermarc
pichlermarc
force-pushed
the
chore/update-webpack-and-karma
branch
from
df2cdf4 to
8d5457b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2269 +/- ##
==========================================
- Coverage 90.97% 90.30% -0.67%
==========================================
Files 146 147 +1
Lines 7492 7234 -258
Branches 1502 1500 -2
==========================================
- Hits 6816 6533 -283
- Misses 676 701 +25 |
|
FYI @JamieDanielson - this is the PR we talked about offline, updates to webpack@5 to align the repo with what we have in core. 🙂 |
JamieDanielson
approved these changes
Jun 10, 2024
david-luna
approved these changes
Jun 10, 2024
trentm
added a commit
to trentm/opentelemetry-js-contrib
that referenced
this pull request
Oct 21, 2024
…or packages Also add mocha to the top-level devDeps. This had a huge impact on the package-lock layout: instead of a mocha install in EVERY workspace subfolder, we get one at the top. This also resolves some errors in `npm ls` currently on main, that were introduced in open-telemetry#2269, e.g.: ``` $ npm ls ├─┬ @opentelemetry/propagator-instana@0.3.2 -> ./propagators/opentelemetry-propagator-instana │ ├── @types/sinon@17.0.3 invalid: "10.0.20" from propagators/opentelemetry-propagator-instana │ ├── karma-chrome-launcher@3.1.1 invalid: "3.1.0" from propagators/opentelemetry-propagator-instana ... ├─┬ @opentelemetry/propagator-ot-trace@0.27.2 -> ./propagators/opentelemetry-propagator-ot-trace │ ├── @types/sinon@17.0.3 invalid: "10.0.20" from propagators/opentelemetry-propagator-ot-trace ... ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates webpack and configs to align with the setup in core, aims to unblock #1152