-
Notifications
You must be signed in to change notification settings - Fork 549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(instrumentation-ioredis): make @types/ioredis a devDependency #2069
fix(instrumentation-ioredis): make @types/ioredis a devDependency #2069
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2069 +/- ##
==========================================
- Coverage 90.97% 90.82% -0.16%
==========================================
Files 146 148 +2
Lines 7492 7672 +180
Branches 1502 1537 +35
==========================================
+ Hits 6816 6968 +152
- Misses 676 704 +28 |
^^ @pichlermarc I enabled, and then disabled auto-merge. This is the first time I tried auto-merge on a PR from a repo that doesn't allow commits to the feature branch from the PR, so I cannot update with the base branch. |
@trentm this must've happened as I'm using an organization fork and did not have maintainer edits enabled. I run a script to enable edits on my PRs via the API as GitHub does not allow enabling maintainer edits via the UI. |
Which problem is this PR solving?
@types/ioredis
is listed as a dependency even though it's types are not part of the `@opentelemetry/instrumentation-ioredis package's public APIShort description of the changes
devDependencies
to avoid it being installed for consumers of the package.Testing
Tested locally by running
npm pack
and then installing the package into a local package with typescript and without@types/ioredis
installed. Imported and instantiated the instrumentation to check that everything still compiles correctly.Fixes #2059