fix: remove postgres example (security) #2171
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
@opentelemetry/instrumentation-postgres
example is outdated (OTel setup gets a tracer from the setup file instead of directly via the API) and (more importantly) the example server shows a questionable approach in building the SQL statement based on unsanitized user input. It's not exploitable as it's just an example (hence the Public PR) but I think it's still important to keep this out of examples 🙂Happy to approve PRs re-adding an updated example in the future.
Edit: This also resolves a CodeQL alert and warnings that may be picked up by other automated code-scanning tools.