Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(aws-sdk): add @trivikr as component owner #2557

Merged

Conversation

trivikr
Copy link
Contributor

@trivikr trivikr commented Nov 27, 2024

Which problem is this PR solving?

Short description of the changes

  • Adds @trivikr as component owner of instrumentation-aws-sdk

Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.75%. Comparing base (0fc1ed3) to head (45e964b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2557   +/-   ##
=======================================
  Coverage   90.75%   90.75%           
=======================================
  Files         169      169           
  Lines        8018     8018           
  Branches     1632     1632           
=======================================
  Hits         7277     7277           
  Misses        741      741           

@trivikr trivikr removed their assignment Nov 27, 2024
Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @trivikr - happy to see you join as a component owner. 🙂

We're currently in the process of adding a requirement that component owners also join the organization so that we can better integrate people into our workflows.

Would you mind opening an issue over at the community repo to join the org? I'll happily sponsor your request to join. I also talked to @blumamir and he said he'd be the second sponsor 🙂

@trivikr
Copy link
Contributor Author

trivikr commented Nov 28, 2024

Thank you, @pichlermarc

I've created an issue on community repo at open-telemetry/community#2470

@pichlermarc
Copy link
Member

Community issue is pending but we can merge this already in the meantime 🙂
Welcome @trivikr 🎉

@pichlermarc pichlermarc merged commit 97ebd4f into open-telemetry:main Dec 1, 2024
11 checks passed
@trivikr trivikr deleted the aws-sdk-component-owner-trivikr branch December 1, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add @trivikr as a component owner of instrumentation-aws-sdk
4 participants