Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add extended request ID to general AWS Attributes #1671

Merged
merged 5 commits into from
Dec 17, 2024

Conversation

trivikr
Copy link
Contributor

@trivikr trivikr commented Dec 11, 2024

Fixes #1670

Changes

Adds extended request ID to general AWS Attributes under aws.extended_request_id

Merge requirement checklist

@trivikr trivikr requested review from a team as code owners December 11, 2024 01:50
@trivikr trivikr force-pushed the aws.extended_request_id branch from 5c4c3c6 to 4f6989b Compare December 11, 2024 02:03
@trivikr
Copy link
Contributor Author

trivikr commented Dec 11, 2024

From my understanding, the schema-next.yaml is not required to be changed, as no existing attribute is being updated. This PR adds a new attribute.

Docs: https://opentelemetry.io/docs/specs/otel/schemas/file_format_v1.0.0/#span_events-section

Copy link
Contributor

@lmolkova lmolkova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please reference this attribute from AWS spans you expect the attribute to be available on - there are quite a few of them defined here https://github.com/open-telemetry/semantic-conventions/blob/main/model/aws/sdk-spans.yml

Also, is it populated by any instrumentations?

@trivikr
Copy link
Contributor Author

trivikr commented Dec 12, 2024

is it populated by any instrumentations?

I've been maintaining AWS SDK for JavaScript for 5+ years, and was recently added as component owner of it's OpenTelemetry Instrumentation in open-telemetry/opentelemetry-js-contrib#2557. I plan to add the attribute as soon as it's merged and released in semantic convention.

AWS SDK for Go Observability solution does use it https://github.com/aws/aws-sdk-go-v2/blob/a164d844a90d8b9f86f8cb827b3fef512eabaabf/service/internal/s3shared/metadata_retriever.go#L53

@trivikr trivikr requested a review from a team as a code owner December 12, 2024 04:12
@trivikr
Copy link
Contributor Author

trivikr commented Dec 12, 2024

Please reference this attribute from AWS spans you expect the attribute to be available on

Added in 24ada32 (#1671)

@trivikr
Copy link
Contributor Author

trivikr commented Dec 12, 2024

The markdown-link-check either incorrectly checks the link from the logs, or the link might have been down when the test was performed.

  ERROR: 1 dead links found in ./docs/system/system-metrics.md !
  [✖] https://blogs.oracle.com/linux/post/understanding-linux-kernel-memory-statistics → Status: 0
make: *** [Makefile:72: markdown-link-check] Error 1

It's failing for other PRs too:

Can you re-run the workflow?

.chloggen/aws.extended_request_id.yaml Outdated Show resolved Hide resolved
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
@lmolkova lmolkova merged commit 01be4a4 into open-telemetry:main Dec 17, 2024
14 checks passed
@trivikr trivikr deleted the aws.extended_request_id branch December 17, 2024 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Add extended request ID to general AWS Attributes
3 participants