Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enable typescript 4.3 option noImplicitOverride #549

Merged
merged 11 commits into from
Jul 12, 2021

Conversation

Flarna
Copy link
Member

@Flarna Flarna commented Jun 26, 2021

Enable typescript 4.3 feature noImplicitOverride to improve code quality.
Adapt code to compile by adding override keyword or avoid overriding.

Update some dev-dependencies and correct some lint warnings.
Configure tsx files to use LF instead CRLF to stay in sync with ts files.

Refs: open-telemetry/opentelemetry-js#2241

Enable typescript 4.3 feature noImplicitOverride to improve code quality.
Adapt code to compile by adding override keyword or avoid overriding.

Update some dev-dependencies and correct some lint warnings.
Configure tsx files to use LF instead CRLF to stay in sync with ts files.
@Flarna Flarna requested a review from a team June 26, 2021 10:56
@codecov
Copy link

codecov bot commented Jun 26, 2021

Codecov Report

Merging #549 (f87ae51) into main (c0ad001) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #549      +/-   ##
==========================================
+ Coverage   94.72%   94.77%   +0.05%     
==========================================
  Files         174      179       +5     
  Lines       10797    10921     +124     
  Branches     1057     1083      +26     
==========================================
+ Hits        10227    10350     +123     
- Misses        570      571       +1     
Impacted Files Coverage Δ
...try-instrumentation-graphql/src/instrumentation.ts 92.72% <100.00%> (ø)
...metry-instrumentation-document-load/src/version.ts 100.00% <0.00%> (ø)
...lemetry-instrumentation-document-load/src/utils.ts 100.00% <0.00%> (ø)
...strumentation-document-load/src/instrumentation.ts 98.79% <0.00%> (ø)
...entation-document-load/src/enums/AttributeNames.ts 100.00% <0.00%> (ø)
...trumentation-document-load/src/enums/EventNames.ts 100.00% <0.00%> (ø)

Copy link
Member

@vmarchaud vmarchaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@obecny obecny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vmarchaud vmarchaud merged commit 902c91f into open-telemetry:main Jul 12, 2021
@Flarna Flarna deleted the ts-override branch July 12, 2021 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants