Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update typescript to 4.3 and enable noImplicitOverride #2241

Merged
merged 2 commits into from
Jun 1, 2021

Conversation

Flarna
Copy link
Member

@Flarna Flarna commented May 28, 2021

Enable typescript 4.3 feature noImplicitOverride to improve code quality and adapt code as needed.
Besides that I updated eslint.

Enable typescript 4.3 feature noImplicitOverride to improve code quality and adapt code as needed.
Besides that I updated eslint.
@codecov
Copy link

codecov bot commented May 28, 2021

Codecov Report

Merging #2241 (4522900) into main (56c032e) will decrease coverage by 0.01%.
The diff coverage is 96.29%.

❗ Current head 4522900 differs from pull request most recent head 0447995. Consider uploading reports for the commit 0447995 to get more accurate results

@@            Coverage Diff             @@
##             main    #2241      +/-   ##
==========================================
- Coverage   92.31%   92.29%   -0.02%     
==========================================
  Files         144      144              
  Lines        5168     5168              
  Branches     1064     1064              
==========================================
- Hits         4771     4770       -1     
- Misses        397      398       +1     
Impacted Files Coverage Δ
...ackages/opentelemetry-shim-opentracing/src/shim.ts 89.60% <92.30%> (ø)
...ages/opentelemetry-exporter-collector/src/types.ts 100.00% <100.00%> (ø)
...s/opentelemetry-instrumentation-fetch/src/fetch.ts 96.98% <100.00%> (ø)
...elemetry-instrumentation-grpc/src/grpc-js/index.ts 90.81% <100.00%> (ø)
...entelemetry-instrumentation-grpc/src/grpc/index.ts 93.04% <100.00%> (ø)
...ges/opentelemetry-instrumentation-http/src/http.ts 95.68% <100.00%> (ø)
...emetry-instrumentation-xml-http-request/src/xhr.ts 96.58% <100.00%> (ø)
...es/opentelemetry-metrics/src/BaseObserverMetric.ts 100.00% <100.00%> (ø)
...ges/opentelemetry-metrics/src/SumObserverMetric.ts 100.00% <100.00%> (ø)
...kages/opentelemetry-node/src/NodeTracerProvider.ts 100.00% <100.00%> (ø)
... and 2 more

Copy link
Member

@obecny obecny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@obecny
Copy link
Member

obecny commented May 31, 2021

@Flarna are you planning to do the same on api and contrib ?

@Flarna
Copy link
Member Author

Flarna commented May 31, 2021

I have already a branch with the changes for API but current version of prettier (used via gts) is not yet ready for override. Once a new prettier version is out I will create a PR there and also for contrib (uses also gts/prettier).

@dyladan
Copy link
Member

dyladan commented Jun 1, 2021

I will remove gts/prettier from API and contrib like I did for this repo.

@dyladan dyladan merged commit d551781 into open-telemetry:main Jun 1, 2021
@Flarna Flarna deleted the ts-4.3 branch June 1, 2021 19:48
@Flarna
Copy link
Member Author

Flarna commented Jun 1, 2021

I will remove gts/prettier from API and contrib like I did for this repo.

Sounds good. But it seems quite some formatting rules got lost in this repo. Not sure if this should be handled first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants