Skip to content

Commit

Permalink
chore: update API docs (#459)
Browse files Browse the repository at this point in the history
* chore: update API docs

* fix: review comment
  • Loading branch information
mayurkale22 committed Oct 25, 2019
1 parent 91fd682 commit 0392064
Show file tree
Hide file tree
Showing 6 changed files with 25 additions and 9 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,12 @@
* DistributedContext}.
*/
export interface EntryValue {
/** `String` value of the `EntryValue`. */
value: string;
/**
* ttl is an integer that represents number of hops an entry can
* propagate.
*/
ttl?: EntryTtl;
}

Expand Down
2 changes: 1 addition & 1 deletion packages/opentelemetry-types/src/metrics/Handle.ts
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ import { SpanContext } from '../trace/span_context';
export interface CounterHandle {
/**
* Adds the given value to the current value. Values cannot be negative.
* @param value the value to add
* @param value the value to add.
*/
add(value: number): void;
}
Expand Down
14 changes: 10 additions & 4 deletions packages/opentelemetry-types/src/trace/SpanOptions.ts
Original file line number Diff line number Diff line change
Expand Up @@ -24,24 +24,30 @@ import { Link } from './link';
* Options needed for span creation
*/
export interface SpanOptions {
/** The SpanKind of a span */
/**
* The SpanKind of a span
* @default {@link SpanKind.INTERNAL}
*/
kind?: SpanKind;

/** A spans attributes */
attributes?: Attributes;

/** Indicates that if this Span is active and recording information like events with the `AddEvent` operation and attributes using `setAttributes`. */
/**
* Indicates that if this Span is active and recording information like
* events with the `AddEvent` operation and attributes using `setAttributes`.
*/
isRecording?: boolean;

/** A spans links */
links?: Link[];

/**
* A parent SpanContext (or Span, for convenience) that the newly-started
* A parent `SpanContext` (or `Span`, for convenience) that the newly-started
* span will be the child of.
*/
parent?: Span | SpanContext;

/** A manually specified start time for the created Span object. */
/** A manually specified start time for the created `Span` object. */
startTime?: number;
}
3 changes: 2 additions & 1 deletion packages/opentelemetry-types/src/trace/link.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,8 @@ import { SpanContext } from './span_context';

/**
* A pointer from the current {@link Span} to another span in the same trace or
* in a different trace.
* in a different trace. Used (for example) in batching operations, where a
* single batch handler processes multiple requests from different traces.
*/
export interface Link {
/** The {@link SpanContext} of a linked span. */
Expand Down
2 changes: 1 addition & 1 deletion packages/opentelemetry-types/src/trace/span_context.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ import { TraceState } from './trace_state';

/**
* A SpanContext represents the portion of a {@link Span} which must be
* serialized and propagated along side of a distributed context.
* serialized and propagated along side of a {@link DistributedContext}.
*/
export interface SpanContext {
/**
Expand Down
8 changes: 6 additions & 2 deletions packages/opentelemetry-types/src/trace/tracer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -70,9 +70,11 @@ export interface Tracer {
* Spans.
*
* If no tracer implementation is provided, this defaults to the W3C Trace
* Context binary format ({@link BinaryFormat}). For more details see
* Context binary format {@link BinaryFormat}. For more details see
* <a href="https://w3c.github.io/trace-context-binary/">W3C Trace Context
* binary protocol</a>.
*
* @returns the {@link BinaryFormat} for this implementation.
*/
getBinaryFormat(): BinaryFormat;

Expand All @@ -81,8 +83,10 @@ export interface Tracer {
* Spans.
*
* If no tracer implementation is provided, this defaults to the W3C Trace
* Context HTTP text format ({@link HttpTraceContext}). For more details see
* Context HTTP text format {@link HttpTextFormat}. For more details see
* <a href="https://w3c.github.io/trace-context/">W3C Trace Context</a>.
*
* @returns the {@link HttpTextFormat} for this implementation.
*/
getHttpTextFormat(): HttpTextFormat;
}

0 comments on commit 0392064

Please sign in to comment.