Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update API docs #459

Merged
merged 3 commits into from
Oct 25, 2019
Merged

Conversation

mayurkale22
Copy link
Member

Which problem is this PR solving?

  • Add missing JSDoc comments.

  • Add known default values.

@codecov-io
Copy link

codecov-io commented Oct 24, 2019

Codecov Report

Merging #459 into master will increase coverage by 0.23%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #459      +/-   ##
==========================================
+ Coverage      95%   95.23%   +0.23%     
==========================================
  Files         125      125              
  Lines        5981     6277     +296     
  Branches      497      516      +19     
==========================================
+ Hits         5682     5978     +296     
  Misses        299      299
Impacted Files Coverage Δ
...opentelemetry-core/src/platform/node/timer-util.ts 33.33% <0%> (-16.67%) ⬇️
...ges/opentelemetry-core/src/common/ConsoleLogger.ts 91.66% <0%> (-3.08%) ⬇️
.../opentelemetry-core/test/metrics/NoopMeter.test.ts 94.87% <0%> (-2.19%) ⬇️
...entelemetry-core/test/common/ConsoleLogger.test.ts 100% <0%> (ø) ⬆️
...ges/opentelemetry-exporter-zipkin/src/transform.ts 100% <0%> (ø) ⬆️
...core/src/context/propagation/NoopHttpTextFormat.ts 100% <0%> (ø) ⬆️
...telemetry-plugin-grpc/test/utils/assertionUtils.ts 100% <0%> (ø) ⬆️
...ges/opentelemetry-core/test/trace/NoopSpan.test.ts 100% <0%> (ø) ⬆️
...entelemetry-exporter-jaeger/test/transform.test.ts 100% <0%> (ø) ⬆️
.../opentelemetry-exporter-zipkin/test/zipkin.test.ts 100% <0%> (ø) ⬆️
... and 21 more

@mayurkale22 mayurkale22 merged commit 0392064 into open-telemetry:master Oct 25, 2019
@mayurkale22 mayurkale22 deleted the update_docs branch October 25, 2019 19:28
pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this pull request Dec 15, 2023
* feat: add ESM builds for packages used in browser

* fix(id-generator-aws-xray): missed including esm files
martinkuba pushed a commit to martinkuba/opentelemetry-js that referenced this pull request Mar 13, 2024
* feat: add ESM builds for packages used in browser

* fix(id-generator-aws-xray): missed including esm files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
document Documentation-related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants