-
Notifications
You must be signed in to change notification settings - Fork 819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update usage of semantic conventions to new exported strings #4567
Comments
I am working on http package |
PR for instrumentation-fetch #4632 |
@JamieDanielson Can I also contribute in this issue? I can start working on this package - @opentelemetry/instrumentation-xml-http-request if no one has picked this up yet. |
Created a PR for instrumentation-xhr here: #4681 |
I am working on core package. |
I'm working on
|
hey, i'm working on:
|
@JamieDanielson hey, i found that in each example in the |
It looks like they are being used for the service name, as seen here in esm-http-ts example. We'll need to replace |
Hey, thanks for the pointers. But i mean that none of the example in the |
Oh! I see what you mean now, sorry I read too fast earlier 😅 . It looks like service names were removed inadvertently during an update and migration of this example a few years back actually, so I see we have two options: either remove the semantic conventions package from the |
No problem at all! Oh i see. Removing the unused dep would be straightforward, but i think we should aim for consistency with the other examples. So, i'm down with the 2nd option too. |
I am going to update the remaining items in the resources package |
Also going to update exporter-zipkin, exporter-jaeger, and exporter-prometheus |
i'm on the |
I'm working on sdk-node and opentelemetry-browser-detector. |
Same as open-telemetry/opentelemetry-js-contrib#2025 for core repo.
This issue is intended to track the necessary change of updating each package to use the new exports for semantic conventions that were added in #4298 and now available in v1.22.0.
Each package will need to
@opentelemetry/semantic-conventions
to"^1.22.0"
HTTP_ROUTE
becomesSEMATTRS_HTTP_ROUTE
Please limit PRs to a single package in order to make them quickly and easily reviewable.
If you are working on one of the below packages, please comment so others know the issue is being worked on.
@opentelemetry/shim-opentracing
refactor(shim-opentracing): Use tree-shakeable string constants for semconv #4746@opentelemetry/sdk-trace-web
refactor(sdk-trace-web): Use tree-shakeable string constants for semconv #4747@opentelemetry/sdk-trace-node
refactor(sdk-trace-node): Use tree-shakeable string constants for semconv #4748@opentelemetry/sdk-trace-base
refactor(sdk-trace-base): Use tree-shakeable string constants for semconv #4749@opentelemetry/resources
chore(resources): update deprecated semconv to use exported strings #4755@opentelemetry/exporter-zipkin
chore(exporters): updated deprecated semconv to use exported strings #4756@opentelemetry/exporter-jaeger
chore(exporters): updated deprecated semconv to use exported strings #4756@opentelemetry/core
refactor(core): Use (tree-shakeable) string constants for semconv #4739@opentelemetry/sdk-node
refactor(sdk-node): Use tree-shakeable string constants for semconv #4767@opentelemetry/instrumentation-xml-http-request
refactor(instrumentation-xhr): use exported strings for semantic attr… #4681@opentelemetry/instrumentation-http
refactor(instr-http): use exported strings for semconv #4573@opentelemetry/instrumentation-grpc
refactor(instr-grpc): move to use SEMATTRS #4633@opentelemetry/instrumentation-fetch
refactor(instr-fetch): move fetch to use SEMATRR #4632@opentelemetry/exporter-prometheus
chore(exporters): updated deprecated semconv to use exported strings #4756@opentelemetry/opentelemetry-browser-detector
docs(opentelemetry-browser-detector): Use tree-shakeable string constants for semconv in Readme #4768The text was updated successfully, but these errors were encountered: