Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(instr-grpc): move to use SEMATTRS #4633

Merged
merged 4 commits into from
Apr 16, 2024
Merged

refactor(instr-grpc): move to use SEMATTRS #4633

merged 4 commits into from
Apr 16, 2024

Conversation

pahiz
Copy link
Contributor

@pahiz pahiz commented Apr 14, 2024

Which problem is this PR solving?

Updates #4567

Short description of the changes

  • Updates deprecated SemanticAttributes in experimental package instrumentation-grpc

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • npm test

Checklist:

  • Followed the style guidelines of this project
  • Unit tests have been added
  • Documentation has been updated

@pahiz pahiz requested a review from a team April 14, 2024 16:21
@pahiz pahiz changed the title Move to use SEMATTRS in instrumental-grpc refactor(instr-fetch): move fetch to use SEMATRR Apr 14, 2024
@pahiz pahiz changed the title refactor(instr-fetch): move fetch to use SEMATRR refactor(instr-grpc): move to use SEMATTRS Apr 14, 2024
pichlermarc
pichlermarc approved these changes Apr 16, 2024
View reviewed changes
Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks 👍

experimental/CHANGELOG.md Outdated Show resolved Hide resolved
@codecov Codecov
Copy link

codecov bot commented Apr 16, 2024

Codecov Report

Merging #4633 (2230896) into main (c046867) will decrease coverage by 5.47%.
Report is 12 commits behind head on main.
The diff coverage is n/a.

❗ Current head 2230896 differs from pull request most recent head 1b12269. Consider uploading reports for the commit 1b12269 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4633      +/-   ##
==========================================
- Coverage   92.83%   87.36%   -5.47%     
==========================================
  Files         329       52     -277     
  Lines        9528     1543    -7985     
  Branches     2053      348    -1705     
==========================================
- Hits         8845     1348    -7497     
+ Misses        683      195     -488

see 288 files with indirect coverage changes

@pichlermarc pichlermarc merged commit 0a750eb into open-telemetry:main Apr 16, 2024
18 checks passed
@pichlermarc pichlermarc mentioned this pull request Apr 19, 2024
Merged
@JamieDanielson JamieDanielson mentioned this pull request Apr 19, 2024
Closed
24 tasks
This was referenced May 19, 2024
Open
Open
@Graysonbarton Graysonbarton mentioned this pull request May 21, 2024
Open
This was referenced May 22, 2024
Open
Open
This was referenced May 28, 2024
Open
Open
Open
Open
This was referenced May 29, 2024
Open
Open
This was referenced Jun 1, 2024
Merged
Closed
@krischarbonneau krischarbonneau mentioned this pull request Jun 5, 2024
Merged
@thiruaws2lab thiruaws2lab mentioned this pull request Jun 12, 2024
Open
@thiruaws2lab thiruaws2lab mentioned this pull request Jun 12, 2024
Open
This was referenced Jun 21, 2024
Open
Open
This was referenced Jun 30, 2024
Open
Open
This was referenced Jun 30, 2024
Open
Open
This was referenced Jun 30, 2024
Open
Open
This was referenced Jun 30, 2024
Open
Open
This was referenced Jul 3, 2024
Open
Open
This was referenced Jul 5, 2024
Open
Open
This was referenced Jul 12, 2024
Open
Open
@DevMockSec DevMockSec mentioned this pull request Jul 17, 2024
Open
This was referenced Jul 18, 2024
Open
Open
This was referenced Jul 24, 2024
Open
Open
@krischarbonneau krischarbonneau mentioned this pull request Jul 30, 2024
Merged
This was referenced Aug 9, 2024
Open
Open
Zirak pushed a commit to Zirak/opentelemetry-js that referenced this pull request Sep 14, 2024
@pahiz @pichlermarc @Zirak
refactor(instr-grpc): move to use SEMATTRS (open-telemetry#4633)
afcf9ee 
* refactor(instr-grpc): move to use SEMATTRS

* Update experimental/CHANGELOG.md

* Update experimental/CHANGELOG.md

---------

Co-authored-by: Marc Pichler <marc.pichler@dynatrace.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pichlermarc pichlermarc pichlermarc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pahiz @pichlermarc