refactor(experimental/examples/opencensus-shim): use new exported string constants for semconv #4763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing constants for semconv
JamieDanielson
approved these changes
Jun 4, 2024
24 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4763 +/- ##
==========================================
- Coverage 91.04% 89.79% -1.25%
==========================================
Files 89 149 +60
Lines 1954 3234 +1280
Branches 416 703 +287
==========================================
+ Hits 1779 2904 +1125
- Misses 175 330 +155 |
pichlermarc
approved these changes
Jun 5, 2024
Merged
via the queue into
open-telemetry:main
with commit Jun 5, 2024
97f372b
20 of 21 checks passed
This was referenced Jun 27, 2024
Closed
Closed
This was referenced Jul 10, 2024
Merged
This was referenced Jul 12, 2024
Closed
Closed
This was referenced Sep 12, 2024
Open
Zirak
pushed a commit
to Zirak/opentelemetry-js
that referenced
this pull request
Sep 14, 2024
…ing constants for semconv (open-telemetry#4763) * refactor(experimental/examples/opencensus-shim): use new exported string constants for semconv * added changelog entry (experimental)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Updates #4567
Short description of the changes
Replaced deprecated import (SemanticResourceAttributes) from @opentelemetry/semantic-conventions with new string constants (SEMRESATTRS_SERVICE_NAME) for the experimental example
opencensus-shimpackageType of change
How Has This Been Tested?
Checklist: