Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't run getting-started for the ts-example #703

Closed
OlivierAlbertini opened this issue Jan 16, 2020 · 0 comments · Fixed by #704
Closed

Can't run getting-started for the ts-example #703

OlivierAlbertini opened this issue Jan 16, 2020 · 0 comments · Fixed by #704
Labels
bug Something isn't working

Comments

@OlivierAlbertini
Copy link
Member

What version of OpenTelemetry are you using?

3.2

What version of Node are you using?

10.9.0

What did you do?

cd getting-started/ts-example 
npm i
npm run start-tracing

What did you expect to see?

I expect to see traces in Zipkin/Jaeger

What did you see instead?

npm ERR! JSON.parse Failed to parse json
npm ERR! JSON.parse Unexpected token } in JSON at position 309 while parsing near '...acing.ts app.ts",
npm ERR! JSON.parse   },
npm ERR! JSON.parse   "author": "Open...'
npm ERR! JSON.parse Failed to parse package.json data.
npm ERR! JSON.parse package.json must be actual JSON, not just JavaScript.

Additional context

Also after fixing this issue, npm run start-tracing didn't work until I add the ts-node in dev deps with the right version (my version was too old I guess)

@OlivierAlbertini OlivierAlbertini added the bug Something isn't working label Jan 16, 2020
OlivierAlbertini added a commit to VilledeMontreal/opentelemetry-js that referenced this issue Jan 16, 2020
add ts-node package

closes open-telemetry#703

Signed-off-by: Olivier Albertini <olivier.albertini@montreal.ca>
mayurkale22 pushed a commit that referenced this issue Jan 17, 2020
add ts-node package

closes #703

Signed-off-by: Olivier Albertini <olivier.albertini@montreal.ca>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant