Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(getting-started): remove extra comma #704

Merged

Conversation

OlivierAlbertini
Copy link
Member

Which problem is this PR solving?

Short description of the changes

  • add ts-node package
  • remove extra comma in package.json

add ts-node package

closes open-telemetry#703

Signed-off-by: Olivier Albertini <olivier.albertini@montreal.ca>
@OlivierAlbertini OlivierAlbertini added document Documentation-related size/XS dependencies Pull requests that update a dependency file labels Jan 16, 2020
@OlivierAlbertini OlivierAlbertini marked this pull request as ready for review January 16, 2020 18:06
@OlivierAlbertini
Copy link
Member Author

ci failed in pg-pool plugin during tsc compile time

@codecov-io
Copy link

codecov-io commented Jan 17, 2020

Codecov Report

Merging #704 into master will increase coverage by 35.04%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           master     #704       +/-   ##
===========================================
+ Coverage    55.9%   90.95%   +35.04%     
===========================================
  Files          69      220      +151     
  Lines        1921    10332     +8411     
  Branches      232      951      +719     
===========================================
+ Hits         1074     9397     +8323     
- Misses        847      935       +88
Impacted Files Coverage Δ
.../opentelemetry-plugin-pg-pool/test/pg-pool.test.ts 88.09% <100%> (ø)
...ges/opentelemetry-core/src/common/ConsoleLogger.ts 90.9% <0%> (-3.21%) ⬇️
...telemetry-core/src/context/propagation/B3Format.ts 95.83% <0%> (-1.31%) ⬇️
...core/src/context/propagation/NoopHttpTextFormat.ts 100% <0%> (ø) ⬆️
packages/opentelemetry-core/src/version.ts 100% <0%> (ø) ⬆️
packages/opentelemetry-core/src/utils/url.ts 100% <0%> (ø) ⬆️
.../opentelemetry-core/src/trace/spancontext-utils.ts 100% <0%> (ø) ⬆️
...ages/opentelemetry-core/src/internal/validators.ts 100% <0%> (ø) ⬆️
...ckages/opentelemetry-core/src/common/NoopLogger.ts 50% <0%> (ø) ⬆️
.../opentelemetry-core/test/metrics/NoopMeter.test.ts 97.22% <0%> (ø)
... and 170 more

@mayurkale22 mayurkale22 merged commit 021bbbb into open-telemetry:master Jan 17, 2020
pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this pull request Dec 15, 2023
…en-telemetry#704)

* refactor(detectors): use values from semantic-conventions package

* chore: tweaks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file document Documentation-related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't run getting-started for the ts-example
5 participants