Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add plugin metapackages #1050

Merged

Conversation

dyladan
Copy link
Member

@dyladan dyladan commented May 13, 2020

Introduce two new packages: @opentelemetry/plugins-node-core and @opentelemetry/plugins-web-core which package all core plugins.

@dyladan
Copy link
Member Author

dyladan commented May 13, 2020

@andrewhsu

@codecov-io
Copy link

codecov-io commented May 13, 2020

Codecov Report

Merging #1050 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1050   +/-   ##
=======================================
  Coverage   95.12%   95.12%           
=======================================
  Files         213      213           
  Lines        8950     8950           
  Branches      806      806           
=======================================
  Hits         8514     8514           
  Misses        436      436           

@dyladan
Copy link
Member Author

dyladan commented May 13, 2020

TODO: add README

Copy link
Member

@mayurkale22 mayurkale22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed in the SIG, please include README.md(including usage section) for both the packages.

metapackages/plugins-node-core/package.json Outdated Show resolved Hide resolved
metapackages/plugins-web-core/package.json Outdated Show resolved Hide resolved
@dyladan
Copy link
Member Author

dyladan commented May 13, 2020

@mayurkale22 think we want one readme to sit in /metapackages/README.md or one for each package?

@mayurkale22
Copy link
Member

@mayurkale22 think we want one readme to sit in /metapackages/README.md or one for each package?

I would prefer in each package, so that in (when we published to) npm you can see the details about the package.

Copy link
Member

@mayurkale22 mayurkale22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dyladan dyladan merged commit 78d8616 into open-telemetry:master May 18, 2020
@dyladan dyladan deleted the plugin-metapackages branch May 18, 2020 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants