Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: 0.8.1 release proposal #1054

Merged
merged 5 commits into from
May 18, 2020
Merged

chore: 0.8.1 release proposal #1054

merged 5 commits into from
May 18, 2020

Conversation

dyladan
Copy link
Member

@dyladan dyladan commented May 13, 2020

mayurkale22
mayurkale22 reviewed May 13, 2020
View reviewed changes
mayurkale22
mayurkale22 approved these changes May 13, 2020
View reviewed changes
Copy link
Member

@mayurkale22 mayurkale22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added one minor comment, otherwise LGTM

@dyladan
Copy link
Member Author

dyladan commented May 14, 2020 •
edited
Loading

Waiting on #1059/#1060

@mayurkale22
Copy link
Member

Waiting on #1059/#1060

Would be nice if you can include #1055 (and strech #1050).

obecny
obecny approved these changes May 18, 2020
View reviewed changes
Copy link
Member

@obecny obecny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dyladan
Copy link
Member Author

dyladan commented May 18, 2020

#1050 has only 2 approvals. Do we want to merge it, wait for more reviews, or just release this without it?

@vmarchaud
Copy link
Member

@dyladan I'm fine with merging it as-is, its just two new packages. There aren't yet documented elsewhere so there is no risk for me

@mayurkale22
Copy link
Member

@dyladan I'm fine with merging it as-is, its just two new packages. There aren't yet documented elsewhere so there is no risk for me

I agreed, I am fine with merging #1050.

@dyladan dyladan merged commit d808ea7 into open-telemetry:master May 18, 2020
@Flarna Flarna deleted the 0.8.1-proposal branch June 12, 2020 21:22
dyladan added a commit to dyladan/opentelemetry-js that referenced this pull request Sep 9, 2022
@dyladan
chore: 0.8.1 release proposal (open-telemetry#1054)
23b574b
pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this pull request Dec 15, 2023
@dyladan
chore: release main (open-telemetry#1054)
8f95ee7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@obecny obecny obecny approved these changes

@vmarchaud vmarchaud vmarchaud approved these changes

@mayurkale22 mayurkale22 mayurkale22 approved these changes

@bg451 bg451 Awaiting requested review from bg451

@markwolff markwolff Awaiting requested review from markwolff

@OlivierAlbertini OlivierAlbertini Awaiting requested review from OlivierAlbertini

@rochdev rochdev Awaiting requested review from rochdev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dyladan @mayurkale22 @vmarchaud @obecny