-
Notifications
You must be signed in to change notification settings - Fork 804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: peer depend on API #2074
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2074 +/- ##
==========================================
- Coverage 93.05% 91.63% -1.43%
==========================================
Files 154 137 -17
Lines 5975 5032 -943
Branches 1246 1044 -202
==========================================
- Hits 5560 4611 -949
- Misses 415 421 +6
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add some test which verifies that api is not added as dependency per accident somewhere in future?
I believe that would be very helpful, as a step within the CI that |
Sure I can probably mock something like that up in the scripts folder |
Depending on the API as a peer dependency in all sdk/instrumention packages leaves the end-user to install a compatible version of the API. In versions of NPM >= 7, this is done automatically. If the user has installed a set of packages which makes this impossible, they will be warned by NPM at install time.