docs(prom-example): remove deprecated startServer #2801
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and destructure DEFAULT_OPTIONS to obtain port endpoint to make log message more compact
naseemkullah
commented
Feb 21, 2022
| @@ -3,16 +3,13 @@ | |||
| const { MeterProvider } = require('@opentelemetry/sdk-metrics-base'); | |||
| const { PrometheusExporter } = require('@opentelemetry/exporter-prometheus'); | |||
|
|
|||
| const exporter = new PrometheusExporter( | |||
| { | |||
| startServer: true, | |||
There was a problem hiding this comment.
I could instead replace with preventStartServer: false but it is implicit so removing altogether
Codecov Report
@@ Coverage Diff @@
## main #2801 +/- ##
=======================================
Coverage 93.42% 93.42%
=======================================
Files 159 159
Lines 5449 5449
Branches 1143 1143
=======================================
Hits 5091 5091
Misses 358 358 |
|
closed in favor of #2802 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and destructure DEFAULT_OPTIONS to obtain port endpoint to make log message more compact