Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(prom-example): remove deprecated startServer option #2802

Merged
merged 2 commits into from
Feb 22, 2022

Conversation

naseemkullah
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Feb 22, 2022

Codecov Report

Merging #2802 (896d878) into main (630a261) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2802   +/-   ##
=======================================
  Coverage   93.41%   93.41%           
=======================================
  Files         159      159           
  Lines        5450     5450           
  Branches     1145     1145           
=======================================
  Hits         5091     5091           
  Misses        359      359           
Impacted Files Coverage Δ
...-metrics-base/examples/metrics/metrics/observer.js 0.00% <0.00%> (ø)

Copy link
Member

@legendecas legendecas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A linter auto-fix may be needed. Otherwise LGTM. 👍

Also, destructure DEFAULT OPTIONS to get port and endpoint

Signed-off-by: Naseem Ullah <24660299+naseemkullah@users.noreply.github.com>
@vmarchaud vmarchaud added the document Documentation-related label Feb 22, 2022
@dyladan dyladan merged commit 144e11a into open-telemetry:main Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
document Documentation-related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants