-
Notifications
You must be signed in to change notification settings - Fork 825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release proposal 1.4.0/0.30.0 #3065
Conversation
Looks like the changelog entry for #2990 has been put into the wrong section of v0.29.0. |
Codecov Report
@@ Coverage Diff @@
## main #3065 +/- ##
==========================================
- Coverage 93.10% 93.08% -0.02%
==========================================
Files 188 188
Lines 6261 6261
Branches 1323 1323
==========================================
- Hits 5829 5828 -1
- Misses 432 433 +1
|
🤔 must have missed that before. Fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for fixing the changelog entry!
We'll need to update the compatibility matrix in |
Are we waiting on a specific PR to release ? |
No just on me to have time since the build takes some time. I'm doing it now |
So, I hate to be That Person, but by semantic versioning, deprecating a Node engine shouldn't be a minor. (Even if it's an EOL engine.) It's a breaking change that's going to affect anyone pulling this package in as a ^1 dependency. |
No problem. Every project gets complaints and we have to hear them somehow.
This was something we discussed for quite a while including talking to spec maintainers and on several SIG calls and was not a decision we took lightly. Deprecating node versions is something we will need to do regularly in the future. We do not want to support EOL versions and node versions expire every year. If we bump the major version each time node is EOL'd, then we will end up having to regularly bump the major version despite not actually changing any interfaces in a breaking way. If you look at the other OTel implementations, you will see they are also doing the same thing (go for example: https://github.com/open-telemetry/opentelemetry-go/releases/tag/v1.3.0). |
1.4.0
🚀 (Enhancement)
🏠 (Internal)
Experimental 0.30.0
💥 Breaking Change
min
/max
recording to Histograms0.18
so thatmin
andmax
can be exported. This change breaks the OTLP/JSON Metric Exporter for all collector versions<0.52
due toopen-telemetry/opentelemetry-collector#5312.
🚀 (Enhancement)
🐛 (Bug Fix)
🏠 (Internal)