-
Notifications
You must be signed in to change notification settings - Fork 819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add node 18 to tests and remove EoL node versions #3048
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3048 +/- ##
==========================================
+ Coverage 92.65% 92.66% +0.01%
==========================================
Files 187 187
Lines 6178 6178
Branches 1304 1304
==========================================
+ Hits 5724 5725 +1
+ Misses 454 453 -1
|
Will the |
@open-telemetry/javascript-maintainers what do you think? Should the engines match the testing matrix? NPM doesn't check the engines field AFAIK but yarn does |
I think the |
…try-js into node-versions-support
@legendecas @Flarna since your approvals I've added a lot of changes (particularly "engines" field) PTAL and make sure you're still happy with your approval |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Imho engines should be updated like it now is. The check can be bypassed if the user feels confident about it, but since they will be stepping into a wild west, it should be a conscious decision.
…try-js into node-versions-support
Based on discussions we've had in several SIG meetings.
https://endoflife.date/nodejs