Detect if we are in onceWrapper #3132
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #3132 +/- ##
==========================================
- Coverage 93.10% 92.71% -0.40%
==========================================
Files 196 181 -15
Lines 6400 5671 -729
Branches 1349 1204 -145
==========================================
- Hits 5959 5258 -701
+ Misses 441 413 -28
|
Flarna
reviewed
Aug 1, 2022
| context: Context | ||
| ) { | ||
| const contextManager = this; | ||
| return function (this: never, event: string, listener: Func<void>) { | ||
| let active = contextManager.active(); |
There was a problem hiding this comment.
Why do you use the active context manager here instead self?
Why do you set a property on context instead within the ContextManager instance?
There was a problem hiding this comment.
I made a new version already I'm closing this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2971
This is an alternative solution to #3123 and #3122