-
Notifications
You must be signed in to change notification settings - Fork 813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent double wrapping event emitter listeners #3133
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3133 +/- ##
==========================================
- Coverage 93.10% 91.15% -1.96%
==========================================
Files 196 68 -128
Lines 6400 1855 -4545
Branches 1349 395 -954
==========================================
- Hits 5959 1691 -4268
+ Misses 441 164 -277
|
@vmarchaud I know you already approved a different one but I prefer this solution. It depends on the sync nature of node but doesn't depend on any implementation details of on/once or the listener |
packages/opentelemetry-context-async-hooks/src/AbstractAsyncHooksContextManager.ts
Show resolved
Hide resolved
This one is also fine to me (since it don't modify the |
Fixes #2971
This is an alternative solution to #3132